New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add transition callbacks to Toast #6674
Conversation
Could you please add tests? Thanks |
Thank you for the review. I've corrected the typo and written a test and an example. It works fine in the example, but the test failed. I noticed that the "onEntered" is not being called, but I couldn't figure out why. Any ideas? Thanks. |
The toast tests uses fake timers so you need to manually advance the clock so code within functions like |
Thank you for the advice!! |
Code and tests look good. The example currently isn't mobile friendly though. I'm thinking we probably don't need the example at all actually, since the props are pretty straight forward. Could you remove the example from this PR? |
Thanks! |
Add animation callbacks to Toast.
Fixes #6152
The previous commit #6261 has not been merged.