Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: range should accept 0 as valid value #337

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

kmorales13
Copy link
Contributor

In the function setRange, range values of 0 will be treated as falsy.
These should be valid, for example, if we want to show only the first slide.

Input:

slides: [1,2,3],
...
range: {
  min: 0,
  max: 0,
}

Output:

minIdx: 0,
maxIdx: 2,

Expected:

minIdx: 0,
maxIdx: 0,

@rcbyr rcbyr merged commit ed0e30d into rcbyr:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants