Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serde feature on playgrounds #103

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

masklinn
Copy link
Contributor

@masklinn masklinn commented Apr 4, 2024

Playground metadata is explicitly inspired by docs.rs so looks very similar, was implemented at rust-lang/rust-playground#326

Example of usage at serde, as well as uuid-rs/uuid#224 for the PR at one of the early adopters / implementers of that system.

@shepmaster looked around a bit, and didn't find any way to test it offline so I assume short of having a bespoke test playground you can only add the metadata and try to remember to check if it works the next time you publish a release?

Fixes #102

Playground metadata is explicitly inspired by docs.rs so looks very similar, was implemented at rust-lang/rust-playground#326
@shepmaster
Copy link

any way to test it offline

Yeah, there isn't such a way, unfortunately. On quick visual inspection it seems reasonable.

check if it works the next time you publish a release

The crate has to be published and then the playground has to be updated, but yeah.

@masklinn
Copy link
Contributor Author

masklinn commented Apr 4, 2024

any way to test it offline

Yeah, there isn't such a way, unfortunately. On quick visual inspection it seems reasonable.

check if it works the next time you publish a release

The crate has to be published and then the playground has to be updated, but yeah.

Thanks, good to know I didn't miss something obvious (for once).

@jswrenn jswrenn added this pull request to the merge queue Apr 4, 2024
Merged via the queue into rayon-rs:main with commit d48ab1b Apr 4, 2024
10 checks passed
@masklinn masklinn deleted the patch-1 branch April 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable serde on playground
3 participants