Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Await gather on list jobs and Move on publish #49996

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Jan 22, 2025

Why are these changes needed?

Two minor changes while looking at scale testing

  • Dashboard jobs api does two gcs calls on which it awaits both. We should kick both off and await together
  • Move publish message on every gcs pubsub service publish

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sorry, something went wrong.

Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah requested a review from a team as a code owner January 22, 2025 01:44
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jan 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jjyao jjyao merged commit 4cb96e2 into ray-project:master Jan 23, 2025
5 checks passed
@dayshah dayshah deleted the jobs-await-gather branch January 23, 2025 19:41
srinathk10 pushed a commit that referenced this pull request Feb 2, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants