bring back theme switcher and remove default version picker #49892
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
can-anyscale
approved these changes
Jan 21, 2025
anson627
pushed a commit
to anson627/ray
that referenced
this pull request
Jan 31, 2025
…ect#49892) Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com> Signed-off-by: Anson Qian <anson627@gmail.com>
anson627
pushed a commit
to anson627/ray
that referenced
this pull request
Jan 31, 2025
…ect#49892) Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com> Signed-off-by: Anson Qian <anson627@gmail.com>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
cristianjd
added a commit
that referenced
this pull request
Feb 11, 2025
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
8 tasks
pcmoritz
pushed a commit
that referenced
this pull request
Feb 11, 2025
Cherry picks the following PRs to version 2.41.0 to fix version switcher issues #49892 #50292 ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
pcmoritz
pushed a commit
that referenced
this pull request
Feb 13, 2025
Cherry picks the following PRs to version 2.39.0 to fix version switcher issues #49892 #50292 ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
anyadontfly
pushed a commit
to anyadontfly/ray
that referenced
this pull request
Feb 13, 2025
…ect#49892) Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com> Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
…ect#49892) Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues - adjusted the CSS to hide the default version picker that was covering the Ask AI button - moved the theme switched to navbar end so it shows up again - add logic so the version detection of the pydata sphynx picker works as expected for `release/2.4.0` for example Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a sphynx update in verson 3.6.0 broke some of the layout this resolves the issues
release/2.4.0for exampleBefore:
After:
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.