feat(barchart)!: allow axes to accept Lines #1273
Merged
+37
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
github-actions
bot
added
the
Type: Breaking Change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
=======================================
- Coverage 94.5% 94.5% -0.1%
=======================================
Files 65 65
Lines 15432 15430 -2
=======================================
- Hits 14597 14595 -2
Misses 835 835 ☔ View full report in Codecov by Sentry. |
joshka
commented
Aug 3, 2024
Comment on lines
+913
to
+915
| Alignment::Left => label.clone().left_aligned(), | ||
| Alignment::Center => label.clone().centered(), | ||
| Alignment::Right => label.clone().right_aligned(), |
There was a problem hiding this comment.
There are usually a fairly small number of short labels here, so the clone is probably ok here.
There was a problem hiding this comment.
Why is it needed in the first place? 🤔 do the alignment methods require ownership?
There was a problem hiding this comment.
Ah, it moves the original… well…
|
Dependencies action is failing due to docker build. |
|
| Report | Sat, August 3, 2024 at 06:03:15 UTC |
| Project | Ratatui |
| Branch | 1273/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| barchart/render/2048 | ➖ (view plot) | 175,790.00 |
| barchart/render/256 | ➖ (view plot) | 108,200.00 |
| barchart/render/64 | ➖ (view plot) | 70,111.00 |
| barchart/render_grouped/2048 | ➖ (view plot) | 319,100.00 |
| barchart/render_grouped/256 | ➖ (view plot) | 118,910.00 |
| barchart/render_grouped/64 | ➖ (view plot) | 106,930.00 |
| barchart/render_horizontal/2048 | ➖ (view plot) | 156,300.00 |
| barchart/render_horizontal/256 | ➖ (view plot) | 74,266.00 |
| barchart/render_horizontal/64 | ➖ (view plot) | 66,949.00 |
| block/render_all_feature/100x50 | ➖ (view plot) | 8,639.90 |
| block/render_all_feature/200x50 | ➖ (view plot) | 15,521.00 |
| block/render_all_feature/256x256 | ➖ (view plot) | 69,445.00 |
| block/render_empty/100x50 | ➖ (view plot) | 4,475.50 |
| block/render_empty/200x50 | ➖ (view plot) | 9,102.00 |
| block/render_empty/256x256 | ➖ (view plot) | 58,797.00 |
| line_render/Center/0 | ➖ (view plot) | 2.48 |
| line_render/Center/10 | ➖ (view plot) | 386.36 |
| line_render/Center/3 | ➖ (view plot) | 215.27 |
| line_render/Center/4 | ➖ (view plot) | 235.65 |
| line_render/Center/42 | ➖ (view plot) | 488.63 |
| line_render/Center/6 | ➖ (view plot) | 244.98 |
| line_render/Center/7 | ➖ (view plot) | 273.91 |
| line_render/Left/0 | ➖ (view plot) | 2.48 |
| line_render/Left/10 | ➖ (view plot) | 350.51 |
| line_render/Left/3 | ➖ (view plot) | 142.82 |
| line_render/Left/4 | ➖ (view plot) | 151.35 |
| line_render/Left/42 | ➖ (view plot) | 490.75 |
| line_render/Left/6 | ➖ (view plot) | 232.85 |
| line_render/Left/7 | ➖ (view plot) | 241.19 |
| line_render/Right/0 | ➖ (view plot) | 2.49 |
| line_render/Right/10 | ➖ (view plot) | 355.93 |
| line_render/Right/3 | ➖ (view plot) | 210.38 |
| line_render/Right/4 | ➖ (view plot) | 247.19 |
| line_render/Right/42 | ➖ (view plot) | 489.63 |
| line_render/Right/6 | ➖ (view plot) | 317.04 |
| line_render/Right/7 | ➖ (view plot) | 355.38 |
| list/render/16384 | ➖ (view plot) | 1,150,200.00 |
| list/render/2048 | ➖ (view plot) | 256,680.00 |
| list/render/64 | ➖ (view plot) | 134,180.00 |
| list/render_scroll_half/16384 | ➖ (view plot) | 1,158,400.00 |
| list/render_scroll_half/2048 | ➖ (view plot) | 259,920.00 |
| list/render_scroll_half/64 | ➖ (view plot) | 90,277.00 |
| paragraph/new/2048 | ➖ (view plot) | 249,660.00 |
| paragraph/new/64 | ➖ (view plot) | 6,169.60 |
| paragraph/new/65535 | ➖ (view plot) | 14,222,000.00 |
| paragraph/render/2048 | ➖ (view plot) | 434,010.00 |
| paragraph/render/64 | ➖ (view plot) | 393,340.00 |
| paragraph/render/65535 | ➖ (view plot) | 1,501,700.00 |
| paragraph/render_scroll_full/2048 | ➖ (view plot) | 386,400.00 |
| paragraph/render_scroll_full/64 | ➖ (view plot) | 415,310.00 |
| paragraph/render_scroll_full/65535 | ➖ (view plot) | 1,462,000.00 |
| paragraph/render_scroll_half/2048 | ➖ (view plot) | 386,350.00 |
| paragraph/render_scroll_half/64 | ➖ (view plot) | 420,440.00 |
| paragraph/render_scroll_half/65535 | ➖ (view plot) | 1,465,300.00 |
| paragraph/render_wrap/2048 | ➖ (view plot) | 221,290.00 |
| paragraph/render_wrap/64 | ➖ (view plot) | 185,820.00 |
| paragraph/render_wrap/65535 | ➖ (view plot) | 1,403,600.00 |
| paragraph/render_wrap_scroll_full/2048 | ➖ (view plot) | 217,310.00 |
| paragraph/render_wrap_scroll_full/64 | ➖ (view plot) | 185,630.00 |
| paragraph/render_wrap_scroll_full/65535 | ➖ (view plot) | 1,398,900.00 |
| sparkline/render/2048 | ➖ (view plot) | 113,000.00 |
| sparkline/render/256 | ➖ (view plot) | 112,460.00 |
| sparkline/render/64 | ➖ (view plot) | 36,058.00 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
orhun
approved these changes
Aug 3, 2024
EdJoPaTo
reviewed
Aug 4, 2024
EdJoPaTo
added a commit
to EdJoPaTo/ratatui
that referenced
this pull request
Aug 4, 2024
BREAKING CHANGES: ratatui#1273 is already breaking and this only advances the already breaking part
EdJoPaTo
added a commit
that referenced
this pull request
Aug 6, 2024
BREAKING CHANGES: #1273 is already breaking and this only advances the already breaking part
joshka
added a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
BREAKING CHANGES: ratatui#1273 is already breaking and this only advances the already breaking part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1272