Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(chart): document chart module #696

Merged
merged 1 commit into from Dec 16, 2023
Merged

Conversation

Valentin271
Copy link
Member

This fixes #386 and completes the documentation for the widgets module apart from canvas.

doc screenshots

image
image
image
image
image

@Valentin271 Valentin271 added this to the v0.25.0 milestone Dec 16, 2023
@Valentin271 Valentin271 added the documentation Improvements or additions to documentation label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (910ad00) 91.7% compared to head (caa2e77) 91.7%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #696   +/-   ##
=====================================
  Coverage   91.7%   91.7%           
=====================================
  Files         42      42           
  Lines      13629   13629           
=====================================
  Hits       12499   12499           
  Misses      1130    1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/widgets/chart.rs Outdated Show resolved Hide resolved
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits

src/widgets/chart.rs Outdated Show resolved Hide resolved
src/widgets/chart.rs Outdated Show resolved Hide resolved
src/widgets/chart.rs Outdated Show resolved Hide resolved
@joshka joshka merged commit f4c8de0 into ratatui-org:main Dec 16, 2023
33 checks passed
@Valentin271 Valentin271 deleted the docs/chart branch December 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: improve general methods documentation
2 participants