docs(examples): add animation and FPS counter to colors_rgb #583
Conversation
Valentin271
requested review from
orhun,
mindoodoo,
sayanarijit,
kdheepak and
Valentin271
as code owners
This doesn't render nicely in VHS yet unfortunately
- Rebased - changed hooks to use color_eyre and shuffled some of the init code - Tweaked the VHS tape (it still renders glitches though) - ran the for loop for setting up colors to 1 larger than the column and row counts to avoid off by one errors
joshka
force-pushed
the
colors-rgb-animation
branch
from
66215e2
to
a29f9a7
Compare
VHS makes glitches in thish gif due to the animation
joshka
force-pushed
the
colors-rgb-animation
branch
3 times, most recently
from
a154dab
to
43617de
Compare
Screen.Recording.2023-12-16.at.5.12.22.PM.mov |
joshka
force-pushed
the
colors-rgb-animation
branch
from
43617de
to
7dcba7c
Compare
joshka
force-pushed
the
colors-rgb-animation
branch
from
7dcba7c
to
490c4b7
Compare
|
Ok - I think this is in the right place now. |
|
Did you tested this? I still got it to panic quite easily. I'm afraid this is related to fps and computer performance. If you didn't got it to panic that's probably the case |
|
I really think this is because the frame changes size between the resize event and the next draw. So I included the Could you try these changes? fix-panic-colors_rgb.patch (had to rename it to .txt to upload on github, you can |
|
The problem is cause by Terminal::draw internally calling autoresize before creating the frame (this is intentiona). If the resize event occurred twice since the previous draw, then the second event may not have been seen by the app (but the size is changed regardless). So the app really can't rely on the size from the resize event to be the size to use for sizing the colors cache. It has to instead use the size from the Frame. |
|
Yep that's what I did in the patch. Ultimately this is going to be a problem in every app that want to use the resize event then ... |
yep |
|
This doesn't render nicely in VHS yet unfortunately (there's some odd screen tearing that happens)
Screen.Recording.2023-10-22.at.3.23.45.AM.mov