feat(block)!: allow custom symbols for borders #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `Block::border_set` method that allows the user to specify the symbols used for the border. Added two new border types: `BorderType::QuadrantOutside` and `BorderType::QuadrantInside`. These are used to draw borders using the unicode quadrant characters (which look like half block "pixels"). ▛▀▀▜ ▌ ▐ ▙▄▄▟ ▗▄▄▖ ▐ ▌ ▝▀▀▘ Fixes: #528 BREAKING CHANGES: - BorderType::to_line_set is renamed to to_border_set - BorderType::line_symbols is renamed to border_symbols
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 90.01% 89.89% -0.13%
==========================================
Files 40 40
Lines 11209 11279 +70
==========================================
+ Hits 10090 10139 +49
- Misses 1119 1140 +21
|
kdheepak
reviewed
Sep 22, 2023
kdheepak
approved these changes
Sep 22, 2023
tonogdlp
pushed a commit
to tonogdlp/ratatui
that referenced
this pull request
Oct 6, 2023
Adds a new `Block::border_set` method that allows the user to specify the symbols used for the border. Added two new border types: `BorderType::QuadrantOutside` and `BorderType::QuadrantInside`. These are used to draw borders using the unicode quadrant characters (which look like half block "pixels"). QuadrantOutside: ``` ▛▀▀▜ ▌ ▐ ▙▄▄▟ ``` QuadrantInside: ``` ▗▄▄▖ ▐ ▌ ▝▀▀▘ ``` Fixes: ratatui-org#528 BREAKING CHANGES: - BorderType::to_line_set is renamed to to_border_set - BorderType::line_symbols is renamed to border_symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
Block::border_setmethod that allows the user to specifythe symbols used for the border.
Added two new border types:
BorderType::QuadrantOutsideandBorderType::QuadrantInside. These are used to draw borders using theunicode quadrant characters (which look like half block "pixels").
Fixes: #528
BREAKING CHANGES: