Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(barchart): divide by zero in render #525

Merged
merged 1 commit into from Sep 21, 2023
Merged

Conversation

joshka
Copy link
Member

@joshka joshka commented Sep 21, 2023

  • fix(table): add default column widths for when none are supplied
  • implement suggestions in comments
  • add docs, correct length calculation
  • simplify logic in constructing constraints
  • add docs to public methods
  • fix overflow panic
  • fix(barchart): avoid divide by zero in rendering

@joshka
Copy link
Member Author

joshka commented Sep 21, 2023

This wasn't meant to have a copy of the table branches in it, just the barchart. rebased

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #525 (9362015) into main (be55a5f) will increase coverage by 0.00%.
The diff coverage is 94.11%.

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          40       40           
  Lines       11193    11209   +16     
=======================================
+ Hits        10075    10090   +15     
- Misses       1118     1119    +1     
Files Changed Coverage Δ
src/widgets/barchart.rs 92.96% <94.11%> (+0.01%) ⬆️

@joshka joshka merged commit c5ea656 into main Sep 21, 2023
33 checks passed
@joshka joshka deleted the fix-constraint-ratio branch September 21, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants