Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Rect): Modify to use saturating ops to prevent arith overflow #523

Merged
merged 1 commit into from Sep 20, 2023

Conversation

HeeillWang
Copy link
Contributor

Fix arithmetic overflow reported on #517 #520

@HeeillWang HeeillWang changed the title Modify to use saturating ops to prevent arith overflow Fix(Rect): Modify to use saturating ops to prevent arith overflow Sep 20, 2023
@HeeillWang HeeillWang changed the title Fix(Rect): Modify to use saturating ops to prevent arith overflow fix(Rect): Modify to use saturating ops to prevent arith overflow Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #523 (8af31e3) into main (c9b8e7c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   90.00%   90.01%           
=======================================
  Files          40       40           
  Lines       11190    11193    +3     
=======================================
+ Hits        10072    10075    +3     
  Misses       1118     1118           
Files Changed Coverage Δ
src/layout.rs 98.38% <100.00%> (+<0.01%) ⬆️

@joshka
Copy link
Member

joshka commented Sep 20, 2023

Hi, thanks for the PR. Would you mind signing your commit with GPG?
See https://docs.github.com/articles/about-gpg/ for more info.

@HeeillWang
Copy link
Contributor Author

Hi, thanks for the PR. Would you mind signing your commit with GPG? See https://docs.github.com/articles/about-gpg/ for more info.

Opps, didn't knew that amending to signed commit also needs another signing...
Signed again, should be no problem now

@joshka joshka merged commit 21303f2 into ratatui-org:main Sep 20, 2023
33 checks passed
@joshka
Copy link
Member

joshka commented Sep 20, 2023

Thanks for the PR. I modified the commit message a little and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants