fix(barchart): fix(barchart): use width() instead of len() to get unicode string length #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthago1
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
karthago1
force-pushed
the
hich/barchart-fix
branch
from
746cf3d
to
89c3cf3
Compare
kdheepak
reviewed
Sep 18, 2023
karthago1
force-pushed
the
hich/barchart-fix
branch
from
89c3cf3
to
7ae70a7
Compare
value_label.len() deliver byte length of the unicode strings, which are not printed as a result. use witdh() instead. Signed-off-by: Ben Fekih, Hichem <hichem.f@live.de>
karthago1
force-pushed
the
hich/barchart-fix
branch
from
7ae70a7
to
15f63ef
Compare
karthago1
changed the title
Codecov Report
@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 89.93% 90.00% +0.07%
==========================================
Files 41 40 -1
Lines 11334 11190 -144
==========================================
- Hits 10193 10072 -121
+ Misses 1141 1118 -23
|
|
I updated the commit message a bit to make it more Changelog friendly and merged this. Thanks for the PR @karthago1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value_label.len() deliver byte length of the unicode strings, which are
not printed as a result.
use witdh() instead.