Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Gauge): add documentation to Gauge #514

Merged
merged 1 commit into from Sep 18, 2023

Conversation

Valentin271
Copy link
Member

Adds documentation to Gauge and LineGauge widgets.

Relates to #386

Screenshots

image

image

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #514 (915e1e4) into main (0c7d547) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          41       41           
  Lines       11334    11334           
=======================================
  Hits        10193    10193           
  Misses       1141     1141           
Files Changed Coverage Δ
src/widgets/gauge.rs 92.42% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are good. Could have a bit more info, but I'd merge this unless you want to make the suggested changes.

src/widgets/gauge.rs Outdated Show resolved Hide resolved
src/widgets/gauge.rs Show resolved Hide resolved
src/widgets/gauge.rs Show resolved Hide resolved
src/widgets/gauge.rs Outdated Show resolved Hide resolved
src/widgets/gauge.rs Outdated Show resolved Hide resolved
src/widgets/gauge.rs Show resolved Hide resolved
@joshka
Copy link
Member

joshka commented Sep 18, 2023

Thanks for making the changes. This looks great!

@joshka joshka merged commit 0fe7385 into ratatui-org:main Sep 18, 2023
33 checks passed
@Valentin271 Valentin271 deleted the docs/gauge branch September 19, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants