Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check compatability with cuDF pandas 2.0 migration #512

Closed
exactlyallan opened this issue Jul 27, 2023 · 6 comments · Fixed by #569
Closed

Check compatability with cuDF pandas 2.0 migration #512

exactlyallan opened this issue Jul 27, 2023 · 6 comments · Fixed by #569
Assignees
@AjayThorve
Labels
1 - On Deck To be worked on next feature request New feature or request

Comments

@exactlyallan
Copy link
Member

Per rapidsai/cudf#13535 check cuxfilter for issues with Pandas 2.0.
@exactlyallan exactlyallan added feature request New feature or request 1 - On Deck To be worked on next labels Jul 27, 2023
@jakirkham
Copy link
Member

Recently cuDF added Pandas 2.x support with PR ( rapidsai/cudf#14916 ). This introduced some breaking changes. Given this, it might be worth checking how cuxfilter is working with cuDF following that upgrade

@bdice
Copy link
Contributor

bdice commented Feb 7, 2024

CI is passing in #568, so it's possible that no changes are needed.

@galipremsagar
Copy link
Contributor

CI is passing in #568, so it's possible that no changes are needed.

It's targeted to 24.02, which is still pandas-1.5.x. So we still need someone to investigate it on 24.04

@bdice
Copy link
Contributor

bdice commented Feb 7, 2024 •
edited

🤦‍♂️ Good eye, @galipremsagar! However, CI also passed yesterday on the CUDA 12.2 PR #563 which targets 24.04. That PR included cudf 24.04.00a356 (build cuda12_py310_240206_g20ed009003_356) and pandas 2.1.4. This was re-run yesterday so I think it's still a sign nothing is needed here?

@jakirkham
Copy link
Member

Based on offline discussion with Ajay, sounds like there is work still needed. He is looking into it

@jakirkham jakirkham mentioned this issue Feb 8, 2024
Merged
@jakirkham
Copy link
Member

WIP fix submitted as PR: #569

@rapids-bot rapids-bot bot closed this as completed in #569 Feb 9, 2024
rapids-bot bot pushed a commit that referenced this issue Feb 9, 2024
@AjayThorve
[Ready for Review] Pandas 2.0 compatibility (#569)
bb275b2 
fixes #512

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Jake Awe (https://github.com/AyodeAwe)
  - Allan (https://github.com/exactlyallan)

URL: #569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AjayThorve AjayThorve

Labels
1 - On Deck To be worked on next feature request New feature or request
Projects
cuxfilter
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ready for Review] Pandas 2.0 compatibility AjayThorve/cuxfilter
5 participants
@jakirkham @bdice @exactlyallan @galipremsagar @AjayThorve