Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JNI] Cleanup MemoryBuffer/ColumnVector close methods to use common code #15354

Open
abellina opened this issue Mar 20, 2024 · 0 comments
Open

Comments

@abellina
Copy link
Contributor

abellina commented Mar 20, 2024

@gerashegalov had a comment in #15351 that I thought would make sense as a follow on. Specifically, we'd like to make a utility available in the JNI code so that classes that need to invoke onClosed can do so with the same common code.

          This is now inconsistent with (Host)ColumnVector. If we cannot consistently move eventHandler.onClosed into a finally please add a comment, but hopefully we can and it could be generalized via some utls withEventHandler(eventHandler) or base class implementation.

Originally posted by @gerashegalov in #15351 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant