Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gtests/ERROR_TEST errors when run in Debug #15317

Merged
merged 1 commit into from Mar 15, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes errors reported by gtests/ERROR_TEST when run with a Debug build. Both errors occur due to invalid stream usage.

[ RUN      ] DebugAssert.cudf_assert_true
libcudf was not built with stacktrace support.
unknown file: Failure
C++ exception with description "cudf_identify_stream_usage found unexpected stream!" thrown in the test body.

[ RUN      ] DebugAssertDeathTest.cudf_assert_false
libcudf was not built with stacktrace support.
/cudf/cpp/tests/error/error_handling_test.cu:112: Failure
Death test: call_kernel()
    Result: threw an exception.
 Error msg:
[  DEATH   ] 
[  DEATH   ] /cudf/cpp/tests/error/error_handling_test.cu:112:: Caught std::exception-derived exception escaping the death test statement. Exception message: cudf_identify_stream_usage found unexpected stream!

Fixes the test logic to use the correct stream. These tests are only built/run with a Debug build.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Mar 15, 2024
@davidwendt davidwendt self-assigned this Mar 15, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 15, 2024
@davidwendt davidwendt marked this pull request as ready for review March 15, 2024 20:27
@davidwendt davidwendt requested a review from a team as a code owner March 15, 2024 20:27
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: Maybe we should change line 79 to something like the following for consistency. No problem even if not 😊:

    auto const stream = cudf::get_default_stream().value();
    kernel<<<1, 1, 0, stream>>>();

@davidwendt
Copy link
Contributor Author

Minor comment: Maybe we should change line 79 to something like the following for consistency.

I'd like to minimize changes to the non-debug code paths since we have started burndown today.
Also, I'm starting on a PR for 24.06 that also updates this source file. I can put the suggested change in there.

@mhaseeb123
Copy link
Member

Thank you Ed. This looks good to merge!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1b163cc into rapidsai:branch-24.04 Mar 15, 2024
75 checks passed
@davidwendt davidwendt deleted the debug-error-test branch March 15, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants