Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOB read in inflate_kernel #15309

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix OOB read in inflate_kernel #15309

merged 2 commits into from
Mar 15, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Mar 14, 2024

Description

Issue #15216

Avoids an OOB read; the read was not causing bugs as the read data was never used.

Addresses the memcheck part of #15216

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Mar 14, 2024
@vuule vuule self-assigned this Mar 14, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 14, 2024
@vuule vuule marked this pull request as ready for review March 15, 2024 16:03
@vuule vuule requested a review from a team as a code owner March 15, 2024 16:04
@vuule
Copy link
Contributor Author

vuule commented Mar 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit f305a55 into rapidsai:branch-24.04 Mar 15, 2024
76 checks passed
@vuule vuule deleted the bug-inflate-oob-read branch March 15, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vuule @bdice @mhaseeb123