Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] CI should test configuring libcudf for static library builds #15275

Closed
bdice opened this issue Mar 11, 2024 · 0 comments · Fixed by #15437
Closed

[FEA] CI should test configuring libcudf for static library builds #15275

bdice opened this issue Mar 11, 2024 · 0 comments · Fixed by #15437
Assignees
Labels
feature request New feature or request

Comments

@bdice
Copy link
Contributor

bdice commented Mar 11, 2024

Is your feature request related to a problem? Please describe.
Some of the CMake code paths used in libcudf builds are different for shared vs. static library builds. This led to a problem where #15178 passed CI, but static builds failed. This broke both spark-rapids-jni (#15270) and cuSpatial wheel builds.

Describe the solution you'd like
We should add a CI job that runs a CMake configure step (but not a full build) for libcudf with -DBUILD_SHARED_LIBS=OFF.

Additional context
PR #15271 fixed the static builds.

@bdice bdice added the feature request New feature or request label Mar 11, 2024
@bdice bdice self-assigned this Mar 11, 2024
@bdice bdice changed the title [FEA] Test libcudf static library builds in CI [FEA] CI should test configuring libcudf for static library builds Mar 11, 2024
@rapids-bot rapids-bot bot closed this as completed in 2584fd9 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant