Fix number of rows in randomly generated lists columns #15248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
shrshi
approved these changes
Mar 7, 2024
ttnghia
reviewed
Mar 7, 2024
| @@ -751,13 +752,16 @@ std::unique_ptr<cudf::column> create_random_column<cudf::list_view>(data_profile | |||
|
|
|||
| // Generate the list column bottom-up | |||
| auto list_column = std::move(leaf_column); | |||
| for (int lvl = 0; lvl < dist_params.max_depth; ++lvl) { | |||
| for (int lvl = dist_params.max_depth; lvl > 0; --lvl) { | |||
There was a problem hiding this comment.
Why are we moving backward/bottom up?
There was a problem hiding this comment.
We've always generated these columns bottom-up, just the value of lvl did not match this. lvl is not used in the loop, outside of the new check.
ttnghia
approved these changes
Mar 7, 2024
bdice
approved these changes
Mar 7, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing
single_level_meanto double introduced a rounding error in the iterative process of generating random lists columns. This PR addressed the issue by enforcing the correct row count in the root lists column.Checklist