Fix ListColumn.to_pandas() to retain list type
#15155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
vyasr
approved these changes
Feb 27, 2024
Comment on lines
+298
to
+299
| # Can't rely on Column.to_pandas implementation for lists. | ||
| # Need to perform `to_pylist` to preserve list types. |
There was a problem hiding this comment.
Presumably this is some bug in how list dtypes are handled in arrow? Do we need to report something upstream?
There was a problem hiding this comment.
There is already an open issue: apache/arrow#34574
mroeschke
reviewed
Feb 27, 2024
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
approved these changes
Feb 28, 2024
galipremsagar
added
5 - Ready to Merge
rjzamora
reviewed
Feb 29, 2024
rjzamora
approved these changes
Mar 4, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
I think there will be a mypy error on main soon as #15182 and #15155 were merge in close succession (my fault for not rebasing first) Also address a review I forgot in https://github.com/rapidsai/cudf/pull/15182/files#r1507154770 cc @galipremsagar Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #14568
This PR fixes
ListColumn.to_pandas()by callingArrowArray.to_pylist()method to retainlisttype in pandas series.Checklist