Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to arrow-14.0.2 #15108

Merged
merged 4 commits into from Feb 22, 2024
Merged

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Feb 21, 2024

Description

This PR upgrades arrow to 14.0.2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 21, 2024
@galipremsagar galipremsagar self-assigned this Feb 21, 2024
@galipremsagar galipremsagar requested review from a team as code owners February 21, 2024 18:20
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. cuDF (Python) Affects Python cuDF API. CMake CMake build issue conda conda issue labels Feb 21, 2024
@galipremsagar galipremsagar changed the title Upgrade to arrow-15 Upgrade to arrow-14.0.2 Feb 21, 2024
pyarrow_run:
common:
- output_types: [conda, requirements, pyproject]
packages:
# Allow runtime version to float up to minor version
# Disallow pyarrow 14.0.0 due to a CVE
- pyarrow>=14.0.1,<15.0.0a0
- pyarrow>=14.0.2,<15.0.0a0
Copy link
Contributor

@bdice bdice Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the lower bound to be 14.0.2? I thought we would build with 14.0.2 and allow >=14.0.1,<15.0.0a0 at runtime to pin the major version for compatibility and continue excluding 14.0.0 due to the CVE.

Same in libarrow_run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for avoiding 14.0.1 here is to skip the issue where we are not able to downgrade the env from 15 to 14.0.1

Copy link
Contributor

@bdice bdice Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline - we want to keep the prior pinnings here for runtime compatibility with any Arrow major version 14 (except 14.0.0 due to the CVE).

dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from a team February 21, 2024 20:50
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 21, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c8dc33c into rapidsai:branch-24.04 Feb 22, 2024
68 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change CMake CMake build issue conda conda issue cuDF (Python) Affects Python cuDF API. improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants