Fixes: #1512 Plugin Engine crashes on types with missing dependencies even when error handlers are disabled. #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies even when error handlers are disabled.
stiemannkj1
commented
Aug 27, 2023
| } catch (Throwable throwable) { | ||
| errored.add(throwable); | ||
| listener.onError(typeDescription, errored); | ||
| return new Dispatcher.Materializable.ForFailedElement(element, typeDescription, errored); | ||
| } |
There was a problem hiding this comment.
Hiding whitespace changes makes the diff more clear here.
raphw
approved these changes
Aug 27, 2023
stiemannkj1
deleted the
issue-1512-engine-crashes-on-types-missing-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.