Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add -D CLI option to enable definition lists #972

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Oct 18, 2024

No description provided.

Verified

This commit was signed with the committer’s verified signature.
eramongodb Ezra Chung
@Martin1887
Copy link
Collaborator

This change has created a compilation error in dos-fuzzer, please check the build errors and fix the problem to get this merged. Thanks!

@ytmimi
Copy link
Contributor Author

ytmimi commented Oct 18, 2024

Happy to make the change, though I think nightly CI is failing because of rust-lang/rust#131833 and not this PR. This is the error from the logs:

error: unused return value of `exec` that must be used
   --> dos-fuzzer/src/main.rs:282:25
    |
282 |                         Command::new(&args[0]).args(&args[1..]).exec();
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D unused-must-use` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_must_use)]`
help: use `let _ = ...` to ignore the resulting value
    |
282 |                         let _ = Command::new(&args[0]).args(&args[1..]).exec();
    |                         +++++++

error: could not compile `dos-fuzzer` (bin "dos-fuzzer") due to 1 previous error

Some recent changes in the compiler (rust-lang/rust 131833) made
`Command::exec` `#[must_use]`.
@Martin1887 Martin1887 merged commit 6d9d712 into pulldown-cmark:master Oct 25, 2024
6 checks passed
@ytmimi ytmimi deleted the definition_list_cli branch October 25, 2024 15:42
@ollpu
Copy link
Collaborator

ollpu commented Dec 13, 2024

This clashes with -D i.e. --enable-subscript

@ytmimi
Copy link
Contributor Author

ytmimi commented Dec 13, 2024

@ollpu I don't think --enable-subscript was available when I put this PR together.

@ytmimi
Copy link
Contributor Author

ytmimi commented Dec 13, 2024

@ollpu yeah, looks like #966 configured -D for --enable-subscript, when it was already being used for definition lists.

@ollpu
Copy link
Collaborator

ollpu commented Dec 13, 2024

Ah, my bad, I just went by the order they were in --help. We'll get this sorted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants