Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issue #120 ... This will update the log-viewer package to work with new Bootstrap 4. Changes include:
In addition to the stock changes to get BS4 working, I also propose some more CSS overrides to make the default layout more readable. BS4 uses rem = 16px as their base font size, as opposed to BS3 (14px), so things are larger by default. I added overrides for:
.sidebar
- smaller font, smaller line height, extra spacing at bottom for small viewport)#table-log
node - get font back to ~14px base for the log table.btn
- make the row-expand button font smaller (BS4 did away with thebtn-xs
class, so we need to compensate)Other elements that are not as space-intensive (example, show X entries, search box, pagination, download/delete links) were left as-is, in the overall new BS4 larger font size.
Happy to discuss any of this if you would like!