Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Bootstrap 4 #122

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Update for Bootstrap 4 #122

merged 2 commits into from
Mar 1, 2018

Conversation

mattlibera
Copy link
Contributor

To address issue #120 ... This will update the log-viewer package to work with new Bootstrap 4. Changes include:

  • updates to meta tags according to BS4 template
  • replacing all glyphicons from BS3 with FontAwesome icons
  • replacing datatables with new version that supports BS4
  • small changes to layout for new BS4 column syntax
  • changes to button that expands each row for BS4 styling and semantics
  • updated jQuery for BS4

In addition to the stock changes to get BS4 working, I also propose some more CSS overrides to make the default layout more readable. BS4 uses rem = 16px as their base font size, as opposed to BS3 (14px), so things are larger by default. I added overrides for:

  • .sidebar - smaller font, smaller line height, extra spacing at bottom for small viewport)
  • entire #table-log node - get font back to ~14px base for the log table
  • .btn - make the row-expand button font smaller (BS4 did away with the btn-xs class, so we need to compensate)

Other elements that are not as space-intensive (example, show X entries, search box, pagination, download/delete links) were left as-is, in the overall new BS4 larger font size.

Happy to discuss any of this if you would like!

@rap2hpoutre
Copy link
Owner

rap2hpoutre commented Mar 1, 2018

👏 BRAVO! Great PR: well explained, clean code, and I just tested it, it works and it's pretty. Thank you!

@rap2hpoutre rap2hpoutre merged commit 2d62e30 into rap2hpoutre:master Mar 1, 2018
@mattlibera
Copy link
Contributor Author

Thanks for the kind words! I'm glad it was helpful, and happy to have the chance to contribute.

Cheers - thanks for this package. It helps us a lot in our enterprise Laravel apps.

@amfsyn
Copy link

amfsyn commented Apr 8, 2019

Why does it download from CDN instead of requiring them as dependencies?

@mattlibera
Copy link
Contributor Author

Why does it download from CDN instead of requiring them as dependencies?

@amfsyn Not sure why you're asking this here. This isn't related to my PR; the view for this package has always utilized CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants