Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug with Unit Input component not updating correctly #13780

Merged
merged 6 commits into from
Mar 18, 2025
Merged

fix bug with Unit Input component not updating correctly #13780

merged 6 commits into from
Mar 18, 2025

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Mar 17, 2025 •
edited
Loading

Summary

Fixes #13784

Occurred changes and/or fixed issues

  • fix UnitInput component by reacting to update:change
  • adjust unit tests
  • bump shell version so that we can release a new version for a partner extension with this fix

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Before

before.mov

After

after.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sorry, something went wrong.

@aalves08
test fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
db66651
@aalves08
working on unit tests
Loading
Loading status checks…
f2e4224
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.12.0 milestone Mar 17, 2025
@aalves08
remove console log
Loading
Loading status checks…
d7c78bc
@aalves08
bump shell version
Loading
Loading status checks…
174236c
@aalves08 aalves08 marked this pull request as ready for review March 17, 2025 15:56
cnotv
cnotv reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I do not test but I'm having issues setting up my instance

cnotv
cnotv previously approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codyrancher
codyrancher previously approved these changes Mar 17, 2025
View reviewed changes
@aalves08 aalves08 changed the title test fix for unit input fix bug with Unit Input component not updating correctly Mar 18, 2025
@aalves08
fix broken unit inputs
Loading
Loading status checks…
bca72d3
@aalves08 aalves08 dismissed stale reviews from codyrancher and cnotv via bca72d3 March 18, 2025 16:12
@aalves08 aalves08 requested review from cnotv and codyrancher March 18, 2025 16:13
@aalves08
Copy link
Member Author

@codyrancher @cnotv @mantis-toboggan-md I went through all of the UnitInput instances on dashboard and found a few "broken" on the Job edit view.

Last review 🙏

@aalves08
fix unit test
Loading
Loading status checks…
2248ba1
@cnotv
Copy link
Member

cnotv commented Mar 18, 2025

@codyrancher @cnotv @mantis-toboggan-md I went through all of the UnitInput instances on dashboard and found a few "broken" on the Job edit view.

Last review 🙏

To be entirely honest with you, I would rather never change anything that is not 100% covered and instead add an exception through a prop to change it. Especially that specific component.

cnotv
cnotv approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 88cbee5 into rancher:master Mar 18, 2025
33 checks passed
edenhernandez-suse pushed a commit that referenced this pull request Mar 26, 2025
@aalves08
fix bug with Unit Input component not updating correctly (#13780)
0a69445 
* test fix

* working on unit tests

* remove console log

* bump shell version

* fix broken unit inputs

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnotv cnotv

@mantis-toboggan-md mantis-toboggan-md

@codyrancher codyrancher

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

Bug with Unit Input component not updating correctly
3 participants
@aalves08 @cnotv @codyrancher