Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Storage class selector not working #12970

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Jan 3, 2025

Summary

Fixes : #12971
As part of Vue 3 migration, we needed to remove @input from compponents that use LabeledSelect

Occurred changes and/or fixed issues

Fixed event listener in StorageClassSelector.
I've checked and other LabeledSelects should be fine (there is a PR for Node Scheduling already). We also have components that are listening for 'search' event, which is not declared on LabeledSelect, but it seems to work and I think will require more investigation.

Technical notes summary

Areas or cases that should be tested

  1. Create a new StorageClass
  2. Apps -> Charts -> Monitoring -> Install/Update -> Prometheus -> Persistent Storage for Prometheus -> Storage Class name -> You should be able to select a storage class
  3. Apps -> Charts -> Monitoring -> Install/Update -> Grafana -> "Enable with PVC Template" Grafana storage -> Storage Class name -> You should be able to select a storage class

Areas which could experience regressions

None

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sorry, something went wrong.

@eva-vashkevich eva-vashkevich merged commit 85b097b into rancher:master Jan 3, 2025
40 checks passed
@eva-vashkevich eva-vashkevich deleted the storageclassselector branch January 3, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage class selector not working in monitoring configuration
2 participants