[FIX] Storage class selector not working #12970
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes : #12971
As part of Vue 3 migration, we needed to remove @input from compponents that use LabeledSelect
Occurred changes and/or fixed issues
Fixed event listener in StorageClassSelector.
I've checked and other LabeledSelects should be fine (there is a PR for Node Scheduling already). We also have components that are listening for 'search' event, which is not declared on LabeledSelect, but it seems to work and I think will require more investigation.
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
None
Screenshot/Video
Checklist