Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyboard nav for about page #12959

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

aalves08
Copy link
Member

Summary

Fixes #12786

Occurred changes and/or fixed issues

  • Fix keyboard nav for about page

Technical notes summary

Areas or cases that should be tested

  • Go to the about page, click on the page and browse the UI elements with the tab key
  • use enter or space key to trigger UI elements on the page

Areas which could experience regressions

Screenshot/Video

Screen.Recording.2024-12-30.at.16.17.42.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sorry, something went wrong.

@aalves08 aalves08 self-assigned this Dec 30, 2024
@aalves08 aalves08 added this to the v2.11.0 milestone Dec 30, 2024
@aalves08 aalves08 requested a review from nwmac January 2, 2025 18:22
@aalves08
Copy link
Member Author

aalves08 commented Jan 3, 2025

@rak-phillip @nwmac PR updated based on last comments

@aalves08 aalves08 requested a review from nwmac January 3, 2025 11:47
@aalves08
Copy link
Member Author

aalves08 commented Jan 3, 2025

Final update @nwmac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation and focus display for about page
3 participants