Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package.json exports section to support node version 10 to 17 #3270

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

barleendhaliwal
Copy link
Contributor

  • npm test passes using node 17 as well as node 10
  • no error thrown on importing files using node 17

Fixes (#3236)

Copy link
Member

@CrossEye CrossEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Any objections?

🌿

@samarpanB
Copy link

@CrossEye when this will be released ? Our test cases are failing due to this. Refer - lo1tuma/eslint-plugin-mocha#322

@CrossEye
Copy link
Member

We're working toward a 1.0 release by trying to close almost all open issues. While we haven't set an actual date, I'm hoping we're done with it by the end of May. 🤞🏼

@perrin4869
Copy link

I'm using eslint-plugin-mocha in my npm modules and this is blocking adding node 18 to the ci matrix, would definitely appreciate a 0.28.2 release!

@mick-feller
Copy link

Any update on when this is going to be released? test cases are failing in latest jest upgrade and this PR fixes that.

@tiggreen
Copy link

tiggreen commented Jul 7, 2022

Same issue on our end so it will be great to release at least a patch version.

@CrossEye
Copy link
Member

CrossEye commented Jul 8, 2022

We've slowed down again. It looks like we may have to do another point release. I'll look into it soon.

@zkochan
Copy link

zkochan commented Aug 3, 2022

Please release this fix.

@tkennedy1-godaddy
Copy link

just chiming in here to find out if this release is still on the radar. Happy to assist in anyway we can.

@rikur
Copy link

rikur commented Feb 27, 2023

Would be great if a fix for this could be released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants