Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport security fix #3212

Merged
merged 2 commits into from
Jan 7, 2022
Merged

backport security fix #3212

merged 2 commits into from
Jan 7, 2022

Conversation

davidchambers
Copy link
Member

This is second step outlined in this comment by @customcommander (the first step was the creation of the v0.27 branch).

I don't know why pushing to GitHub does not trigger automated tests. 馃し

davidchambers and others added 2 commits January 6, 2022 12:11
* Security fix for ReDoS

Security fix for ReDoS vulnerability.

* Update trim.js

* Update trim.js

* Update trim.js
@customcommander
Copy link
Member

customcommander commented Jan 6, 2022

I don't know why pushing to GitHub does not trigger automated tests. 馃し

I think that's probably because the GH workflow simply doesn't exist. The workflow as introduced by @hitmands was introduced after the initial v0.27 release IIRC so your branch doesn't have it :-)

If Travis was supposed to run then I have no idea. Perhaps it was disabled when GH workflow was introduced?

@davidchambers davidchambers merged commit 4d8e8f0 into v0.27 Jan 7, 2022
@davidchambers davidchambers deleted the davidchambers/trim branch January 7, 2022 21:12
@CrossEye
Copy link
Member

It used to run in Travis. Although it would be interesting to know why it stopped, that's pretty low priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants