-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golang version not aligned at .github/workflows #62
Conversation
👷 Deploy request for inspiring-brown-e0fe87 pending review.Visit the deploys page to approve it
|
Hi @rajatjindal, thank you for creating Btw, I'm aware there was a comment under pr12 back in 2020 explained why keeping It would be nice if you have some time to review this PR. Thanks! |
fyi, it would be easier to review via TAB: commits, I've split my commits into several topics. |
Out of curiosity: why remove vendor? |
Simply trying to make source tree clear and reduce diff-lines for the following commits. |
I think I should leave it to original author @rajatjindal to decide when to upgrade packages and how to manage packages. So I decided to revert commits for package version changes. Commits still available here at my personal fork. |
|
||
RUN mkdir -p /home/app | ||
WORKDIR /home/app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WORKDIR
will create the directory so that we could remove mkdir
here.
@@ -1,21 +1,21 @@ | |||
FROM golang:1.17.3-alpine3.14 as builder | |||
FROM golang:1.17-alpine3.15 as builder | |||
|
|||
WORKDIR /go/src/github.com/rajatjindal/krew-release-bot | |||
COPY . . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without .dockerignore
it will copy all files including sensitive/unnecessary info such as commit history inside .git/*
.
thanks a lot for your PR |
golang 1.17
andalpine 3.15
.gitignore
to prevent sensitive data being packed into docker imagePR build
Test