Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake test fails with ruby3.2.0 preview3 and onwards #769

Closed
mtasaka opened this issue Dec 12, 2022 · 1 comment
Closed

rake test fails with ruby3.2.0 preview3 and onwards #769

mtasaka opened this issue Dec 12, 2022 · 1 comment

Comments

@mtasaka
Copy link

mtasaka commented Dec 12, 2022

With sprockets git head ( 1276b43 ), $ bundle exec rake fails with ruby3.2.0preview3 and onwards like:

$ bundle exec rake
Run options: --seed 36636

# Running:

........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S.....................................F.........................................................................................S................S............S..................................................................................S......................S.S.............................................................................................................................................

Finished in 42.726871s, 21.3449 runs/s, 95.7945 assertions/s.

  1) Failure:
TestURIUtils#test_split_file_uri [/builddir/build/GIT/sprockets/test/test_uri_utils.rb:42]:
--- expected
+++ actual
@@ -1 +1 @@
-["file", nil, "/etc/fstab", nil]
+["file", "", "/etc/fstab", nil]


912 runs, 4093 assertions, 1 failures, 0 errors, 7 skips

This is because of ruby/ruby@dd5118f : with ruby 3.2.0, URI.split sets empty string for host instead of nil.

@mtasaka
Copy link
Author

mtasaka commented Dec 27, 2022

Actually this is fixed by #771, especially 39490de

@mtasaka mtasaka closed this as completed Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant