Fix leaky test: #54578
Merged
Fix leaky test: #54578
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix rails#51347 - The tests in this suite are leaky which results in other tests from other suite from sometimes failing. The problem is due to modifying some database tables while a prepared statement on Postgreql already exists. This causes Postgres to report an error "cached plan must not change result type". The order of reproduction is as follow: - We have more than one connection in the pool (Let's say Conn1 and Conn2 for the sake of the example) - A first test runs a query, Conn1 is used, we prepare a statement. - The leaky test modify some table on Conn2. - A third test runs a query, Conn1 is used, the query was prepared. Postgresql reports the "cached plan must not change result type". This commis fixes that by clearing the statement cache on each connection.
|
Backport please? 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
PessimisticLockingTest#test_no_locks_no_waitgetsERROR: cached plan must not change result type#51347The tests in this suite are leaky which results in other tests from other suite from sometimes failing.
The problem is due to modifying some database tables while a prepared statement on Postgreql already exists. This causes Postgres to report an error "cached plan must not change result type".
The order of reproduction is as follow:
This commis fixes that by clearing the statement cache on each
connection.
cc/ @yahonda