Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary executable bit from docker-entrypoint.tt #54295

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Remove unnecessary executable bit from docker-entrypoint.tt #54295

merged 1 commit into from
Jan 20, 2025
+7 −0

Conversation

jdufresne
Copy link
Contributor

Motivation / Background

This Pull Request has been created because the docker-entrypoint.tt template doesn't require the executable permission bit as it isn't executed on its own. Its rendered file "bin/docker-entrypoint" does require the executable bit which continues to be set in AppBuilder#dockerfiles. In general, it is a best practice to only apply the executable bit when the files is expected to be run.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Sorry, something went wrong.

@jdufresne
Remove unnecessary executable bit form docker-entrypoint.tt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c670e6e 
The docker-entrypoint.tt template doesn't require the executable
permission bit as it isn't executed on its own. It's rendered file
"bin/docker-entrypoint" does require the executable bit which continues
to be set in AppBuilder#dockerfiles.
@rails-bot rails-bot bot added the railties label Jan 20, 2025
@jdufresne jdufresne changed the title Remove unnecessary executable bit form docker-entrypoint.tt Remove unnecessary executable bit fromm docker-entrypoint.tt Jan 20, 2025
@jdufresne jdufresne changed the title Remove unnecessary executable bit fromm docker-entrypoint.tt Remove unnecessary executable bit from docker-entrypoint.tt Jan 20, 2025
@kamipo kamipo merged commit b2b0b13 into rails:main Jan 20, 2025
3 checks passed
@jdufresne jdufresne deleted the dockerfiles branch January 20, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdufresne @kamipo