-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci skip] Remove guide docs for rackup
#53533
Conversation
Rackup now recommends to not use it: https://github.com/rack/rackup?tab=readme-ov-file#soft-deprecation I'd wager a guess and say that most apps (in a rails context) are already using either `bin/rails server` or just invoke their chosen server directly anyways. Additionally, this info outdated. `config.ru` is already generated in such a way that users don't have to change anything.
I think this change makes sense. rails/railties/railties.gemspec Line 43 in 32dcdca
Edit: I guess not as ActionPack still supports Rack 2: rails/actionpack/actionpack.gemspec Line 39 in 32dcdca
|
It's not so easy. Even with Rack 3 only, there is a dependency here:
You would need to inline a bunch from this class: https://github.com/rack/rackup/blob/8d32c964c3ab7495b6fc59f30d83ae3d80bb4851/lib/rackup/server.rb Rails does its own argument parsing, handles middleware by itself, does not expose profiling like rackup does, and probably more. I'm not sure how much relevant code would actually be left in the end (doesn't look too bad honestly) but it's definitly more involved and I'm sure there's need for deprecation somewhere as well. |
That Rackup::Server is referencing this: |
Also related "Require Rack 3": #50565 |
Still, anything extra to this PR will indeed be easier when Rack 2 is dropped. |
[ci skip] Remove guide docs for `rackup`
Rackup now recommends to not use it: https://github.com/rack/rackup?tab=readme-ov-file#soft-deprecation
I'd wager a guess and say that most apps (in a rails context) are already using either
bin/rails server
or just invoke their chosen server directly anyways.Additionally, this info outdated.
config.ru
is already generated in such a way that users don't have to change anything: https://github.com/rails/rails/blob/32dcdcaef666e0043b0df844aa167201d50f8c9c/railties/lib/rails/generators/rails/app/templates/config.ru.tt