Fix add_reference options validated on < 7.1 #50680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
force-pushed
the
hm-fix-legacy-add-reference
branch
2 times, most recently
from
5dd74dd
to
d5ab550
Compare
Option validation was [added][1] for 7.1+ Migration classes, and a compatibility layer was added to ensure that previous Migration versions do not have their options validated. However, the add_reference method was missing in the compatibility layer which results in pre 7.1 Migrations validating options passed to add_reference. This commit fixes the issue by adding add_reference to the compatibility layer. In addition to adding add_reference to the "no validation" compatibility test, the test is refactored to run against each previous migration version to ensure that they all behave consistently. [1]: e6da3eb
rafaelfranca
force-pushed
the
hm-fix-legacy-add-reference
branch
from
d5ab550
to
71b4e22
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jan 15, 2024
Fix add_reference options validated on < 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Option validation was added for 7.1+ Migration classes, and a compatibility layer was added to ensure that previous Migration versions do not have their options validated. However, the add_reference method was missing in the compatibility layer which results in pre 7.1 Migrations validating options passed to add_reference.
Detail
This commit fixes the issue by adding add_reference to the compatibility layer. In addition to adding add_reference to the "no validation" compatibility test, the test is refactored to run against each previous migration version to ensure that they all behave consistently.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]