Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples to #slice and #values_at documentation [ci-skip] #50679

Merged
merged 1 commit into from Jan 12, 2024
Merged

Add examples to #slice and #values_at documentation [ci-skip] #50679

merged 1 commit into from Jan 12, 2024

Conversation

p8
Copy link
Member

@p8 p8 commented Jan 9, 2024 •
edited

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

brendanh-katalyst
brendanh-katalyst reviewed Jan 12, 2024
View reviewed changes
Copy link

@brendanh-katalyst brendanh-katalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@p8
Copy link
Member Author

p8 commented Jan 12, 2024

Thanks @brendanh-katalyst

@p8 p8 merged commit 8944d80 into rails:main Jan 12, 2024
3 checks passed
@p8 p8 deleted the activerecord/values-at-example branch January 12, 2024 10:58
p8 added a commit to p8/rails that referenced this pull request Jan 12, 2024
@p8
Add examples to #slice and #values_at documentation [ci-skip] (rails#…
ffcf708 
…50679)
p8 added a commit that referenced this pull request Jan 12, 2024
@p8
Add examples to #slice and #values_at documentation [ci-skip] (#50679) (
620d335 
#50736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanh-katalyst brendanh-katalyst brendanh-katalyst left review comments

Assignees
No one assigned
Labels
activemodel activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p8 @brendanh-katalyst