Load the model schema when running test in eager load context #49470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some protections like the one that checks if an enum is pointing to a valid column in the table only works when the database schema is loaded to the model. Before this change, if schema cache wasn't present and the right combinations of configurations were not set, developers would only see this exception in production. With this change, those errors would be caught on CI, as soon the tests are loaded.
|
Failures are because our CI sets the |
Since `load_schema` is private API, we don't want it to be explicitly called by RSpec. This feature can be used by RSpec by exposing it in `rails/testing/maintain_test_schema` so they don't need to reimplement the same thing.
rafaelfranca
force-pushed
the
rm-eager-load-model-schema
branch
from
4329c95
to
aa4e713
Compare
rafaelfranca
force-pushed
the
rm-eager-load-model-schema
branch
from
2e3f073
to
90a278e
Compare
rafaelfranca
force-pushed
the
rm-eager-load-model-schema
branch
2 times, most recently
from
ee4aec2
to
18081c6
Compare
rafaelfranca
force-pushed
the
rm-eager-load-model-schema
branch
from
18081c6
to
47742fa
Compare
Right now we are using both to test the Rails applications we generate and to test Rails itself. Let's keep CI for the app and BUILDKITE to the framework.
rafaelfranca
force-pushed
the
rm-eager-load-model-schema
branch
from
47742fa
to
1f0262a
Compare
rafaelfranca
added a commit
that referenced
this pull request
Oct 4, 2023
Load the model schema when running test in eager load context
matsales28
added a commit
to matsales28/shoulda-matchers
that referenced
this pull request
Nov 10, 2023
This commit fixes the problem of not finding the tables when running the specs in eager load mode, this was introduced by Rails 7.1. Load the model schema when running test in eager load context rails/rails#49470
matsales28
added a commit
to thoughtbot/shoulda-matchers
that referenced
this pull request
Nov 17, 2023
* Add Rails 7.1 to appraisals * fix: Adjust validate options when managing columns and tables in migration This commit adjusts the way we manage columns and tables in migrations to account for the changes in Rails 7.1.0, it was introduced in this Rails version a validation around the options passed to tables and columns in migrations, so we need to adjust our code to skip this validation. This PR introduced this new validation on the migrations: rails/rails#46178 * Refine `ActiveRecord::SerializeMatcher` for Rails 7.1 compatibility This commit refines the `ActiveRecord::SerializeMatcher` to accommodate changes in the public API introduced in Rails 7.1. The `serialize` method's API has been updated, necessitating adjustments to our matcher specs to align with the new API. While this PR addresses the immediate need for compatibility, there is potential for further enhancements and refinements in the matcher's implementation to bring it in line with the revised public API. However, such improvements will be explored in a future PR. For reference, the changes in the public API can be found in the following PR: rails/rails#47463 This commit adjusts the `ActiveRecord::SerializeMatcher` the public API for the `serialize` method has changed on Rails 7.1, so we had to * feat: Upadte workflow matrix * fix: Adjust comparison between hash and `ActionController::Parameters` The behavior of the comparison between hash and a `ActionController::Parameters` was changed and now will be deprecated. Check this Rails PR for more context rails/rails#44826. * fix: Adjust usage of `has_secure_token` without a token attr The behaviour of this method was changed in Rails 7.1, and now it'll search for a `token` attr in the initialization of the record instead of the creation. To stay with the same behaviour as before it's necessary to pass a new argument `on: : create` to the method. * fix: Adjust specs for primary_key check * fix: Test updating error_highlight gem * fix: Add default Rails tables to acceptance spec This commit fixes the problem of not finding the tables when running the specs in eager load mode, this was introduced by Rails 7.1. Load the model schema when running test in eager load context rails/rails#49470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some protections like the one that checks if an enum is pointing to a valid column in the table only works when the database schema is loaded to the model.
Before this change, if schema cache wasn't present and the right combinations of configurations were not set, developers would only see this exception in production.
With this change, those errors would be caught on CI, as soon the tests are loaded.