Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby:master re: ruby/feature/18285 #47457

Merged
merged 1 commit into from Feb 22, 2023
Merged

Conversation

zzak
Copy link
Member

@zzak zzak commented Feb 22, 2023

Behavior was changed in ruby/ruby#6950.

https://bugs.ruby-lang.org/issues/18285

Before

Failure:
TimeWithZoneTest#test_no_method_error_has_proper_context [/Users/zzak/code/rails/activesupport/test/core_ext/time_with_zone_test.rb:1098]:
Expected /undefined\ method\ `this_method_does_not_exist'\ for\ Fri,\ 31\ Dec\ 1999\ 19:00:00\.000000000\ EST\ \-05:00:ActiveSupport::TimeWithZone/ to match # encoding: US-ASCII
#    valid: true
"undefined method `this_method_does_not_exist' for an instance of ActiveSupport::TimeWithZone".
Failure:
LazyViewRenderTest#test_undefined_method_error_references_named_class [/Users/zzak/code/rails/actionview/test/template/render_test.rb:343]:
Expected /`undefined' for #<ActionView::Base:0x[0-9a-f]+>/ to match # encoding: US-ASCII
#    valid: true
"undefined local variable or method `undefined' for an instance of #<Class:0x000000010a330508>".

@@ -340,7 +340,7 @@ def test_render_sub_template_with_errors

def test_undefined_method_error_references_named_class
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It not longer references the named class in Ruby 3.3 🤔

ruby/ruby#6950

Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
@rails-bot rails-bot bot added the railties label Feb 22, 2023
@byroot byroot merged commit 5594c6c into rails:main Feb 22, 2023
@zzak zzak deleted the ruby-3.3/feature/18285 branch February 22, 2023 11:20
zzak pushed a commit to zzak/rails that referenced this pull request Feb 22, 2023
byroot added a commit that referenced this pull request Feb 22, 2023
skipkayhil pushed a commit to skipkayhil/rails that referenced this pull request Jan 2, 2024
dhh pushed a commit that referenced this pull request Jan 2, 2024
Fix ruby:master re: ruby/feature/18285

Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants