New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ruby:master re: ruby/feature/18285 #47457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
force-pushed
the
ruby-3.3/feature/18285
branch
from
February 22, 2023 10:20
9f1da18
to
3c3fd0b
Compare
zzak
commented
Feb 22, 2023
@@ -340,7 +340,7 @@ def test_render_sub_template_with_errors | |||
|
|||
def test_undefined_method_error_references_named_class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It not longer references the named class in Ruby 3.3 🤔
zzak
force-pushed
the
ruby-3.3/feature/18285
branch
from
February 22, 2023 10:23
3c3fd0b
to
1e40065
Compare
ruby/ruby#6950 Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
zzak
force-pushed
the
ruby-3.3/feature/18285
branch
from
February 22, 2023 10:41
1e40065
to
67748d0
Compare
zzak
pushed a commit
to zzak/rails
that referenced
this pull request
Feb 22, 2023
Fix ruby:master re: ruby/feature/18285
byroot
added a commit
that referenced
this pull request
Feb 22, 2023
Backport #47457 to fix Ruby 3.3 tests
skipkayhil
pushed a commit
to skipkayhil/rails
that referenced
this pull request
Jan 2, 2024
Fix ruby:master re: ruby/feature/18285
dhh
pushed a commit
that referenced
this pull request
Jan 2, 2024
Fix ruby:master re: ruby/feature/18285 Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior was changed in ruby/ruby#6950.
https://bugs.ruby-lang.org/issues/18285
Before