Remove unnecessary isolation_level setting from load_defaults 7.0 #46617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The default value of
ActiveSupport::IsolatedExecutionState.isolation_level
is set to:thread
, regardless of whetherload_defaults 7.0
is used or not.If so, there is no need to set this in
load_defaults 7.0
. This Pull Request has been created to remove this unnecessary setting.Or if there is any reason to set this in
load_defaults 7.0
, I would like to know that.Detail
This Pull Request simply removes this setting.
Additional information
I confirmed that
ActiveSupport::IsolatedExecutionState.isolation_level
returns:thread
on Rails 7.0.4 withload_defaults 6.1
.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]