Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Use an affirmative conditional and use --exact to avoid regex in conditional #174

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

olleolleolle
Copy link
Contributor

...and avoid regex in match.

Example:

$ gem list ails

*** LOCAL GEMS ***

breadcrumbs_on_rails (4.1.0)
cssbundling-rails (1.3.3, 1.3.2, 1.2.0, 1.1.2)
dotenv-rails (2.8.1)
factory_bot_rails (6.2.0)
mjml-rails (4.9.0, 4.8.0)
omniauth-rails_csrf_protection (1.0.1)
premailer-rails (1.12.0)
pry-rails (0.3.9)
rails (7.1.0.beta1, 7.0.8, 7.0.7.2, 7.0.7, 7.0.6, 7.0.5.1, 7.0.5, 7.0.4.3, 7.0.3.1, 6.1.7.3)
rails-controller-testing (1.0.5)
rails-dom-testing (2.2.0, 2.1.1, 2.0.3)
rails-html-sanitizer (1.6.0, 1.5.0)
rails_autolink (1.1.8)
rspec-rails (6.0.3, 6.0.2, 6.0.1)
rubocop-rails (2.21.2, 2.21.1, 2.21.0, 2.20.2, 2.20.0, 2.19.1, 2.19.0, 2.18.0)
sass-rails (6.0.0)
sassc-rails (2.1.2)
sprockets-rails (3.4.2)
turbo-rails (1.0.1)
$ gem list --exact ails

*** LOCAL GEMS ***

...and avoid regex in match.

(Try a gem list ails vs a gem list --exact ails to see what I mean.)
@dhh dhh merged commit ddebd51 into rails:main Jan 5, 2024
@olleolleolle olleolleolle deleted the patch-1 branch January 5, 2024 16:48
dorianmarie pushed a commit to dorianmarie/cssbundling-rails that referenced this pull request Jan 19, 2024
There are different bin/dev being generated by cssbundling-rails and jsbundling-rails

See rails/jsbundling-rails#174

> dev: Use an affirmative conditional
>
> ...and avoid regex in match.
>
> (Try a gem list ails vs a gem list --exact ails to see what I mean.)
dhh pushed a commit to rails/cssbundling-rails that referenced this pull request Jan 19, 2024
There are different bin/dev being generated by cssbundling-rails and jsbundling-rails

See rails/jsbundling-rails#174

> dev: Use an affirmative conditional
>
> ...and avoid regex in match.
>
> (Try a gem list ails vs a gem list --exact ails to see what I mean.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants