Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Bun priting loaded env variables on STDERR #131

Merged
merged 1 commit into from Sep 16, 2023
Merged

Conversation

byroot
Copy link
Member

@byroot byroot commented Sep 16, 2023

Fix: #130

@byroot
Copy link
Member Author

byroot commented Sep 16, 2023

I git blamed this redirection all the way down to 80b3aa3.

It's really unclear why outputs were merged, but I don't see the need for it.

We can likely let the external runtime inherit STDERR, this way errors will be visible by the user.

But of course like any change to such old behavior, there is an amount of risk...

@byroot byroot marked this pull request as ready for review September 16, 2023 17:11
@byroot byroot merged commit daf5b2b into master Sep 16, 2023
29 of 30 checks passed
@byroot byroot deleted the bun-env-file branch September 16, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun runtime fails if there's an .env file in the working directory
1 participant