r-lib/setup-r can now only install rtools40, not rtools42 or 43 #720

sorhawell · 2023-04-21T20:58:45Z

Hello wonderful people :)

Describe the bug
Since 21 hours ago r-lib/setup-r either stopped installing rtoolsXX OR installing old rtools40 even though specifying 42 or 43.

current setup-r either install 40 although 43 was specified ...

Run r-lib/actions/setup-r@v[2](https://github.com/pola-rs/r-polars/actions/runs/4768599259/jobs/8478100393#step:9:2)
  with:
    r-version: release
    use-public-rspm: true
**update-rtools: true**  <- if TRUE setup-r only installs rtools40
**    rtools-version: 43**
    Ncpus: 2
    remove-openmp-macos: true
    install-r: true
    windows-path-include-rtools: true
    windows-path-include-mingw: true
  env:
    GITHUB_PAT: ***
    R_KEEP_PKG_SOURCE: yes
    rust-toolchain: nightly-gnu
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
    CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
    CACHE_ON_FAILURE: true
D:\a\_temp\R-[4](https://github.com/pola-rs/r-polars/actions/runs/4768599259/jobs/8478100393#step:9:4).2.3-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R
c:\rtools40\usr\bin\bash.exe --login -c "pacman -Syu --noconfirm" <- 40 not 43

... or does not install any rtools if update_rtools is not set/False

Run r-lib/actions/setup-r@v[2](https://github.com/pola-rs/r-polars/actions/runs/4763628251/jobs/8467276020#step:9:2)
  with:
    r-version: release
    use-public-rspm: true
    **rtools-version: 42**
    Ncpus: 2
    remove-openmp-macos: true
    install-r: true
    windows-path-include-rtools: true
    windows-path-include-mingw: true
    update-rtools: false
  env:
    GITHUB_PAT: ***
    R_KEEP_PKG_SOURCE: yes
    rust-toolchain: nightly-gnu
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
    CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
    CACHE_ON_FAILURE: true
D:\a\_temp\R-4.2.[3](https://github.com/pola-rs/r-polars/actions/runs/4763628251/jobs/8467276020#step:9:3)-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R
C:\ProgramData\Chocolatey\bin\choco.exe install ghostscript --no-progress
Chocolatey v1.3.1
Installing the following packages:
ghostscript
By installing, you accept licenses for the packages.

Before run installs rtools42 as speciefied

Run r-lib/actions/setup-r@v[2](https://github.com/pola-rs/r-polars/actions/runs/4759816665/jobs/8459472963#step:9:2)
  with:
    r-version: release
    use-public-rspm: true
    rtools-version: 42
    Ncpus: 2
    remove-openmp-macos: true
    install-r: true
    windows-path-include-rtools: true
    windows-path-include-mingw: true
    update-rtools: false
  env:
    GITHUB_PAT: ***
    R_KEEP_PKG_SOURCE: yes
    rust-toolchain: nightly-gnu
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
    CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
    CACHE_ON_FAILURE: true
D:\a\_temp\R-4.2.[3](https://github.com/pola-rs/r-polars/actions/runs/4759816665/jobs/8459472963#step:9:3)-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R
Downloading https://github.com/r-hub/rtools[4](https://github.com/pola-rs/r-polars/actions/runs/4759816665/jobs/8459472963#step:9:4)2/releases/download/latest/rtools42.exe...
**D:\a\_temp\rtools42.exe /VERYSILENT /SUPPRESSMSGBOXES**
C:\ProgramData\Chocolatey\bin\choco.exe install ghostscript qpdf --no-progress
Chocolatey v1.3.1
Installing the following packages:
ghostscript;qpdf
By installing, you accept licenses for the packages.
**no rtools was installed**

To Reproduce
It appears to me, that your builds does not install rtools 42 or 43 it seems

Run ./setup-r
  with:
    r-version: release
    use-public-rspm: true
    Ncpus: 1
    remove-openmp-macos: true
    install-r: true
    windows-path-include-rtools: true
    windows-path-include-mingw: true
    update-rtools: false
  env:
    GITHUB_PAT: ***
    R_KEEP_PKG_SOURCE: yes
D:\a\_temp\R-4.[2](https://github.com/r-lib/actions/actions/runs/4768111196/jobs/8477061688#step:4:2).[3](https://github.com/r-lib/actions/actions/runs/4768111196/jobs/8477061688#step:4:3)-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R
C:\ProgramData\Chocolatey\bin\choco.exe install ghostscript --no-progress
Chocolatey v1.3.1
Installing the following packages:
ghostscript
By installing, you accept licenses for the packages.

Ghostscript.app v10.0.0.20230317 [Approved]
ghostscript.app package files install completed. Performing other installation steps.
Installing 6[4](https://github.com/r-lib/actions/actions/runs/4768111196/jobs/8477061688#step:4:4) bit version
Installing Ghostscript.app...
Ghostscript.app has been installed.
  ghostscript.app may be able to be automatically uninstalled.
Environment Vars (like PATH) have changed. Close/reopen your shell to
 see the changes (or in powershell/cmd.exe just type `refreshenv`).
 The install of ghostscript.app was successful.
  Software installed as 'exe', install location is likely default.

Ghostscript v10.0.0.2023031[7](https://github.com/r-lib/actions/actions/runs/4768111196/jobs/8477061688#step:4:7) [Approved]
ghostscript package files install completed. Performing other installation steps.
 The install of ghostscript was successful.
  Software installed to 'C:\ProgramData\chocolatey\lib\Ghostscript'

Chocolatey installed 2/2 packages. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Expected behavior
Installs the correct version of rtools, all extendr R packages need >= rtools42

Additional context
main extendr CI pipelines have the same error now https://github.com/extendr/rextendr/actions/runs/4765374782/jobs/8472263529?pr=263

gaborcsardi · 2023-04-21T21:36:56Z

Thanks for the report! This should be fixed now, can you please try again?

sorhawell · 2023-04-21T22:25:10Z

that was a very impressive response time :) thank you so much

In some cases it does. This is a very workable start for the rust-extendr people.

- { os: windows-latest, r: "release", rtools-version: "42" }   #no 
no install of rtools visable
- https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330416#step:9:1
correlates with missing linker first included from 42
 - https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330416#step:13:80


- { os: windows-latest, r: "release", rtools-version: "" }       #yes
visible install of rtools42
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330308#step:9:1
correlates with ok compilation

- { os: windows-latest, r: "devel", rtools-version: "43" }      #yes
visible install of rtools43
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330615#step:9:1
correlates with ok compilation


- { os: windows-latest, r: "devel", rtools-version: "" }          #yes
visible install of rtools43
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330516#step:9:1
correlates with ok compilation

- { os: windows-latest, r: "oldrel-1", rtools-version: "42" }   #no 
no visible rtools install
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330809#step:9:1
correlates with missing linker first included from 42
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330809#step:13:80


- { os: windows-latest, r: "oldrel-1", rtools-version: "" }       #yes
visible install of rtools
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330697#step:9:1
correlates with ok compilation

gaborcsardi · 2023-04-21T22:29:36Z

I am not entirely sure what you mean, but it works like this:

if you specify rtools-version, that is installed,
otherwise it determines the version automatically:
- R >= 4.3.0 gets Rtools43
- 4.3.0 > R >= 4.0.0 gets Rtools40 (preinstalled currently)
- R < 4.0.0 gets Rtools35

sorhawell · 2023-04-21T22:30:30Z

yeah that was a fuzzy answer, is it more clear now ?

gaborcsardi · 2023-04-21T22:31:08Z

Can you please link directly to the output of the job(s) within the builds that do not work as they should?

Edit: never mind, I think I got it.

gaborcsardi · 2023-04-21T22:34:27Z

Here you don't specify it, and current R-release (4.2.3) needs Rtools40, which is pre-installed:
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330416#step:9:1

And the same applies to oldrel-1 (4.1.x):
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330809#step:9:1

sorhawell · 2023-04-21T22:43:47Z

does it make sense now? It seems, I should currently avoid specifying the version, otherwise it will fail for release and oldrel-1

gaborcsardi · 2023-04-21T22:55:15Z

No, your build failed when you didn't specify the rtools version, see the links in my comment, e.g. here: https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330416#step:9:3

When you specified it, it worked:
https://github.com/pola-rs/r-polars/actions/runs/4769095301/jobs/8479330308#step:9:5

Btw. do not rely on the order of jobs in the matrix, that might not be the same as the order of the display.

Btw. 2, you could include the rtools version specification in the name of the job.

sorhawell · 2023-04-21T23:11:36Z

@gaborcsardi you're absolutely right, thank you for your patience :)

Then I agree this is resolved. Many thanks again.

github-actions · 2023-05-06T01:38:30Z

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

sorhawell added the bug an unexpected problem or unintended behavior label Apr 21, 2023

gaborcsardi closed this as completed in 1b13849 Apr 21, 2023

This was referenced Apr 21, 2023

"linker x86_64-w64-mingw32.static.posix-gcc.exe not found" error on Windows build pola-rs/r-polars#153

Closed

WIP: Fix windows compilation pola-rs/r-polars#155

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r-lib/setup-r can now only install rtools40, not rtools42 or 43 #720

r-lib/setup-r can now only install rtools40, not rtools42 or 43 #720

sorhawell commented Apr 21, 2023 •

edited

gaborcsardi commented Apr 21, 2023

sorhawell commented Apr 21, 2023 •

edited

gaborcsardi commented Apr 21, 2023 •

edited

sorhawell commented Apr 21, 2023

gaborcsardi commented Apr 21, 2023 •

edited

gaborcsardi commented Apr 21, 2023

sorhawell commented Apr 21, 2023

gaborcsardi commented Apr 21, 2023

sorhawell commented Apr 21, 2023

github-actions bot commented May 6, 2023

r-lib/setup-r can now only install rtools40, not rtools42 or 43 #720

r-lib/setup-r can now only install rtools40, not rtools42 or 43 #720

Comments

sorhawell commented Apr 21, 2023 • edited

gaborcsardi commented Apr 21, 2023

sorhawell commented Apr 21, 2023 • edited

gaborcsardi commented Apr 21, 2023 • edited

sorhawell commented Apr 21, 2023

gaborcsardi commented Apr 21, 2023 • edited

gaborcsardi commented Apr 21, 2023

sorhawell commented Apr 21, 2023

gaborcsardi commented Apr 21, 2023

sorhawell commented Apr 21, 2023

github-actions bot commented May 6, 2023

sorhawell commented Apr 21, 2023 •

edited

sorhawell commented Apr 21, 2023 •

edited

gaborcsardi commented Apr 21, 2023 •

edited

gaborcsardi commented Apr 21, 2023 •

edited