Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: wasteful allocation of datagrammer and stream state tracker for non-datagram requests #4515

Open
marten-seemann opened this issue May 14, 2024 · 1 comment · May be fixed by #4544
Open

http3: wasteful allocation of datagrammer and stream state tracker for non-datagram requests #4515

marten-seemann opened this issue May 14, 2024 · 1 comment · May be fixed by #4544
Labels
enhancement

Comments

@marten-seemann
Copy link
Member

We can probably save quite a few allocs here.
@Qjawko
Copy link

Qjawko commented Jun 1, 2024 •
edited

Hi, we can reduce number of allocs by using ringbuffer with initialized size streamDatagramQueueLen, can do a PR
Or we can just use sized slice that will never grow

@Qjawko Qjawko linked a pull request Jun 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use ringbuffer Qjawko/quic-go
2 participants
@marten-seemann @Qjawko