Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: add support for HTTP Datagrams (RFC 9297) #4452

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Apr 21, 2024

Fixes #3522. Closes #4444. Closes #4430. Depends on #4445 and #4460.

Doesn't rely on the OnStateChange stream API (#4428).

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 91.59664% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (11b1159) to head (f962f28).

Files Patch % Lines
http3/conn.go 87.10% 6 Missing and 6 partials ⚠️
http3/datagram.go 95.08% 2 Missing and 1 partial ⚠️
http3/http_stream.go 72.73% 3 Missing ⚠️
http3/client.go 90.48% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
+ Coverage   84.73%   84.80%   +0.07%     
==========================================
  Files         152      154       +2     
  Lines       14478    14645     +167     
==========================================
+ Hits        12267    12419     +152     
- Misses       1704     1714      +10     
- Partials      507      512       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the http3-datagrams-wrap-stream branch 2 times, most recently from 1dbc83d to b06cb09 Compare April 21, 2024 13:31
@marten-seemann marten-seemann force-pushed the http3-datagrams-wrap-stream branch 4 times, most recently from cb6b4ae to d29f687 Compare April 23, 2024 14:51
@marten-seemann marten-seemann marked this pull request as ready for review April 25, 2024 20:23
@marten-seemann marten-seemann merged commit 2a37c53 into master Apr 26, 2024
34 checks passed
@marten-seemann marten-seemann deleted the http3-datagrams-wrap-stream branch April 26, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http3: implement HTTP Datagrams and Capsules (RFC 9297)
1 participant