http3: use a log/slog Logger for logging #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4449 +/- ##
==========================================
- Coverage 84.75% 84.61% -0.14%
==========================================
Files 152 152
Lines 14371 14377 +6
==========================================
- Hits 12179 12164 -15
- Misses 1691 1709 +18
- Partials 501 504 +3 ☔ View full report in Codecov by Sentry. |
rfwatson
approved these changes
Apr 20, 2024
Comment on lines
+84
to
+86
| if c.Logger != nil { | ||
| c.Logger.Debug("setting up connection failed", "error", err) | ||
| } |
There was a problem hiding this comment.
Question: should we always fallback to slog.Default() if no logger is explicitly set?
There was a problem hiding this comment.
I'm not sure. I don't want to spam peoples' logs with debug messages, so I'm inclined to leave it as is far now. That said, I don't think we have a good / consistent logging philosophy at the moment, so I'd be happy to discuss and revise this decision in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4366. Closes #3548.