Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation for CancelWrite after Close on the send stream #4419

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Apr 8, 2024

Fixes #4404. Closes #4411. Closes #4408. Closes #4413.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (e310b80) to head (2ed56bb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4419      +/-   ##
==========================================
+ Coverage   84.88%   84.89%   +0.01%     
==========================================
  Files         152      152              
  Lines       14359    14359              
==========================================
+ Hits        12188    12190       +2     
+ Misses       1671     1670       -1     
+ Partials      500      499       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sukunrt
Copy link
Collaborator

sukunrt commented Apr 10, 2024

We need #4408 too right? That handles the case where the stream close has been ACKed. In that case this CancelWrite should be a no-op

@marten-seemann
Copy link
Member Author

We need #4408 too right? That handles the case where the stream close has been ACKed. In that case this CancelWrite should be a no-op

Debatable. Technically yes, but it seems to be such a corner case that is doesn't really matter.

@marten-seemann marten-seemann merged commit 857c31d into master Apr 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow remote-triggered stream resets after closing a send stream CancelWrite after Close should be a no-op
2 participants