Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: rename Server.SetQuicHeaders to Server.SetQUICHeaders #4377

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Mar 22, 2024

Server.SetQuicHeaders is deprecated now, and will be removed at some point in the future.

Server.SetQuicHeaders is deprecated now, and will be removed at some
point in the future.
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (e14dd2f) to head (4981ceb).

Files Patch % Lines
http3/server.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4377      +/-   ##
==========================================
+ Coverage   84.88%   84.89%   +0.01%     
==========================================
  Files         151      151              
  Lines       14334    14336       +2     
==========================================
+ Hits        12167    12170       +3     
+ Misses       1668     1667       -1     
  Partials      499      499              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann changed the title http3: fix capitalization of Server.SetQUICHeaders http3: rename Server.SetQuicHeaders to Server.SetQUICHeaders Mar 23, 2024
@marten-seemann marten-seemann merged commit 7d90254 into master Mar 23, 2024
34 checks passed
@marten-seemann marten-seemann deleted the http3-set-quic-header-capitalization branch March 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant