Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Transport.VerifySourceAddress to control the Retry Mechanism #4362

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

marten-seemann
Copy link
Member

This can be used to rate-limit handshakes originating from unverified source addresses. Rate-limiting for handshakes can be implemented using the GetConfigForClient callback on the Config.

@marten-seemann marten-seemann added this to the v0.42 milestone Mar 11, 2024
@marten-seemann marten-seemann linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (497d3f5) to head (b3037da).

Files Patch % Lines
server.go 91.30% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4362   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files         151      151           
  Lines       14353    14327   -26     
=======================================
- Hits        12184    12162   -22     
+ Misses       1669     1667    -2     
+ Partials      500      498    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This can be used to rate-limit handshakes originating from unverified
source addresses. Rate-limiting for handshakes can be implemented using
the GetConfigForClient callback on the Config.
@marten-seemann marten-seemann merged commit 9971fed into master Mar 15, 2024
34 checks passed
@marten-seemann marten-seemann deleted the verify-source-address branch March 15, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current rate limiting is ineffective
1 participant