http3: don't automatically set RoundTripper.QuicConfig.EnableDatagrams #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user provides a quic.Config, we shouldn't modify it. Instead, we should return an error if the user enables HTTP Datagrams but fails to enable datagrams on the QUIC layer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4340 +/- ##
==========================================
+ Coverage 84.80% 84.83% +0.03%
==========================================
Files 150 150
Lines 14251 14254 +3
==========================================
+ Hits 12085 12092 +7
+ Misses 1668 1665 -3
+ Partials 498 497 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user provides a quic.Config, we shouldn't modify it. Instead, we should return an error if the user enables HTTP Datagrams but fails to enable datagrams on the QUIC layer.
This isn't required by RFC 9297. If the QUIC layer disables datagrams, one could - in principe - use the Capsule protocol. However, that's probably never (?) intended by the user.