Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Connection.{Send,Receive}Message to {Send,Receive}Datagram #4116

Merged
merged 1 commit into from Oct 25, 2023

Conversation

marten-seemann
Copy link
Member

This is more consistent with both the RFC and the rest of the API. For example, the option in the Config is already name EnableDatagrams, and the property in the ConnectionState is named SupportsDatagrams.

This is more consistent with both the RFC and the rest of the API. For
example, the option in the Config is already name EnableDatagrams, and
the property in the ConnectionState is named SupportsDatagrams.
@marten-seemann marten-seemann added this to the v0.40 milestone Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4116 (b994c0d) into master (36f7fe7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #4116   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files         150      150           
  Lines       15421    15421           
=======================================
  Hits        12913    12913           
+ Misses       2010     2009    -1     
- Partials      498      499    +1     
Files Coverage Δ
interface.go 0.00% <ø> (ø)
connection.go 72.84% <0.00%> (ø)

... and 2 files with indirect coverage changes

@marten-seemann marten-seemann merged commit 1c631cf into master Oct 25, 2023
32 checks passed
@marten-seemann marten-seemann deleted the rename-datagram-methods branch October 28, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants